-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add atomone-testnet-1 #5875
base: master
Are you sure you want to change the base?
Conversation
30b6aaa
to
6114721
Compare
6114721
to
eca3aae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment about the website.
9716104
to
eca3aae
Compare
Feel free to add mine as well. "persistent_peers": "rest": "rpc": |
}, | ||
"images": [ | ||
{ | ||
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/testnets/atomonetestnet1/images/atomone.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the uploaded images here under testnets/atomonetestnet1/images/ since they are duplicates of mainnet logo.
@@ -0,0 +1,38 @@ | |||
{ | |||
"$schema": "../../assetlist.schema.json", | |||
"chain_name": "atomonetestnet1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the non-numbered chain_name fist, and then use the number suffixes for additional or archived testnets
No description provided.