Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add atomone-testnet-1 #5875

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

albttx
Copy link
Contributor

@albttx albttx commented Jan 29, 2025

No description provided.

@albttx albttx force-pushed the atomone-testnet branch 2 times, most recently from 30b6aaa to 6114721 Compare January 29, 2025 10:41
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment about the website.

testnets/atomonetestnet1/chain.json Outdated Show resolved Hide resolved
@doma2k
Copy link

doma2k commented Jan 29, 2025

Feel free to add mine as well.

"persistent_peers":
"id": "43bf1528ab28c5dcbf0005fec0d6252f66f30ed8",
"address": "162.55.135.119:26056"

"rest":
"address": "https://atomone-testnet-api.domanodes.com",
"provider": "Doma🏠Nodes"

"rpc":
"address": "https://atomone-testnet-rpc.domanodes.com",
"provider": "Doma🏠Nodes"

},
"images": [
{
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/testnets/atomonetestnet1/images/atomone.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the uploaded images here under testnets/atomonetestnet1/images/ since they are duplicates of mainnet logo.

@@ -0,0 +1,38 @@
{
"$schema": "../../assetlist.schema.json",
"chain_name": "atomonetestnet1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the non-numbered chain_name fist, and then use the number suffixes for additional or archived testnets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants