test: add fee test with wrong denom order #3493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/e2e/e2e_test.go
Outdated
| @@ -86,7 +91,40 @@ func (s *IntegrationTestSuite) TestSlashing() { | |||
| s.testSlashing(chainAPI) | |||
| } | |||
|
|
|||
| // todo add fee test with wrong denom order | |||
| func (s *IntegrationTestSuite) TestFeeWithWrongDenomOrder() { | |||
There was a problem hiding this comment.
Looks good. Can you move this to be a function in e2e_bank_test.go and invoke it from within the TestBank function?
tests/e2e/e2e_test.go
Outdated
Comment on lines
121
to
125
| // The transaction should still be accepted and processed correctly | ||
| // despite the fees being in a different order | ||
| tx, err := s.chainA.SignAndBroadcastTx(val1.keyInfo, txBuilder) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(uint32(0), tx.Code) |
There was a problem hiding this comment.
Would be good to use a require.Eventually block like in
gaia/tests/e2e/e2e_bank_test.go
Line 40 in accd997
|
Hey @Eric-Warehime, I've addressed your review comments:
|
Your test is failing and not passing lint. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to verify that transactions with fees in non-standard denomination order are processed correctly.
This ensures that the chain is resilient to different orderings of fee denominations in transactions.
The test creates a transaction with fees ordered as "stake" then "atom" and verifies successful processing.