DOC-14441-correlation ID#1105
Merged
Merged
Conversation
idulo
requested changes
Jun 19, 2026
idulo
previously approved these changes
Jun 24, 2026
pasin
reviewed
Jun 24, 2026
| throws CouchbaseLiteException { | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration(db1, new DatabaseEndpoint(db2)); | ||
| config.setReplicatorType(ReplicatorConfiguration.ReplicatorType.PUSH_AND_PULL); | ||
| CollectionConfiguration collectionConfig = new CollectionConfiguration(db1.getDefaultCollection()); |
Contributor
There was a problem hiding this comment.
Should remove the above old code (2 lines) as well.
pasin
requested changes
Jun 25, 2026
| throws CouchbaseLiteException { | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration(db1, new DatabaseEndpoint(db2)); | ||
| config.setReplicatorType(ReplicatorConfiguration.ReplicatorType.PUSH_AND_PULL); | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration( |
Contributor
There was a problem hiding this comment.
This hasn't been fixed yet.
The config was created twice with two the (deprecated) way and the new way. Can you delete line 156 and 157?
| throws CouchbaseLiteException { | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration(db1, new DatabaseEndpoint(db2)); | ||
| config.setReplicatorType(ReplicatorConfiguration.ReplicatorType.PUSH_AND_PULL); | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration( |
Contributor
There was a problem hiding this comment.
The config was created twice with two the (deprecated) way and the new way.
| throws CouchbaseLiteException { | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration(db1, new DatabaseEndpoint(db2)); | ||
| config.setReplicatorType(ReplicatorConfiguration.ReplicatorType.PUSH_AND_PULL); | ||
| ReplicatorConfiguration config = new ReplicatorConfiguration( |
Contributor
There was a problem hiding this comment.
The config was created twice with two the (deprecated) way and the new way.
pasin
requested changes
Jun 25, 2026
| ReplicatorConfiguration config = new ReplicatorConfiguration( | ||
| Set.of(collectionConfig), | ||
| new DatabaseEndpoint(db2) | ||
| ); |
Contributor
There was a problem hiding this comment.
Please change to the followings:
public Replicator runReplicator(Database db1, Database db2, ReplicatorChangeListener listener)
throws CouchbaseLiteException {
CollectionConfiguration collectionConfig =
new CollectionConfiguration(db1.getDefaultCollection());
ReplicatorConfiguration config = new ReplicatorConfiguration(
Set.of(collectionConfig),
new DatabaseEndpoint(db2)
);
| ReplicatorConfiguration config = new ReplicatorConfiguration( | ||
| Set.of(collectionConfig), | ||
| new DatabaseEndpoint(db2) | ||
| ); |
Contributor
There was a problem hiding this comment.
Please change to the followings:
public Replicator runReplicator(Database db1, Database db2, ReplicatorChangeListener listener)
throws CouchbaseLiteException {
CollectionConfiguration collectionConfig =
new CollectionConfiguration(db1.getDefaultCollection());
ReplicatorConfiguration config = new ReplicatorConfiguration(
Set.of(collectionConfig),
new DatabaseEndpoint(db2)
);
| ReplicatorConfiguration config = new ReplicatorConfiguration( | ||
| Set.of(collectionConfig), | ||
| new DatabaseEndpoint(db2) | ||
| ); |
Contributor
There was a problem hiding this comment.
Please change to the followings:
public Replicator runReplicator(Database db1, Database db2, ReplicatorChangeListener listener)
throws CouchbaseLiteException {
CollectionConfiguration collectionConfig =
new CollectionConfiguration(db1.getDefaultCollection());
ReplicatorConfiguration config = new ReplicatorConfiguration(
Set.of(collectionConfig),
new DatabaseEndpoint(db2)
);
pasin
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs Issue: DOC-14441
PR to add correlation ID to 3.4 release
Preview URL:
https://preview.docs-test.couchbase.com/docs-couchbase-lite-DOC-14441-correlation-id
You will need the Docs Team credentials on Confluence.