Improve concurrency: fewer goroutines #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
snej
force-pushed
the
CBG-2952-better-concurrency
branch
3 times, most recently
from
85478ad to
2d6ce1a
Compare
- Don't create new goroutines to encode/decode Message bodies. - Message state that's only needed while receiving or sending is broken out into new structs msgSender and msgStreamer. - New API for handling requests. Added AsyncHandler type, Dispatcher interface, and some Dispatcher implementations for typical tasks like handler-per-Profile and limited concurrency. - New ThreadPool class for handling requests asynchronously without spawning more goroutines. - receiver goroutine blocks and stops reading from the socket when the total size of received-but-unhandled requests exceeds a limit. (This exerts backpressure on the client.) CBG-2952
Most of them were about capitalized error messages...
snej
force-pushed
the
CBG-2952-better-concurrency
branch
from
2d6ce1a to
011516c
Compare
If an incomplete incoming reply has already been dispatched to the app, don't change its body to an error when the connection closes. Also made receiver.closePendingResponses() be called on the receiver's parseLoop's goroutine, not the sender's.
Member
|
Attempted to quickly resolve conflicts just to keep this branch alive. Not overly confident in what I merged though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-2952
Note to reviewers:
The two commits here are best reviewed individually. One contains the real work; the rest just fixes a bunch of Go compiler warnings that have accumulated over time (mostly about capitalized error messages.)