This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Fix players variable reliance of TicTacToe app code #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snario
changed the title
ldct
approved these changes
Jun 5, 2019
cf19drofxots
approved these changes
Jun 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TicTacToe client logic depended on the
playersvariable in theAppStateof theTicTacToe. However, we could not rely on this anymore since the Interpreter PR (#1263) removed this variable from the contract. Now that it is gone, we rely on thebeneficiariesfield of theAppInstancethat @IIIIllllIIIIllllIIIIllllIIIIllllIIIIll added. This field is temporary (since it is hard coded to a specific interpreter but happens to be getting written to in the Install Protocol (see [1]).Also, separately, the
interpreterParamsfor theTwoPartyEthAsLump.solinterpreter were being incorrectly set, this fixes that.[1]
monorepo/packages/node/src/protocol/install.ts
Line 143 in 6fe51b1