This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Add limitOrTotal and beneficiaries to client API wrapper class (also rename them to be explicit) #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf19drofxots
reviewed
Jun 7, 2019
|
Renamed all of the fields in the codebase also to much more clearly labelled variables. |
snario
changed the title
cf19drofxots
reviewed
Jun 7, 2019
cf19drofxots
suggested changes
Jun 7, 2019
cf19drofxots
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields were not added in the Interpreter PR #1263 (cc: @IIIIllllIIIIllllIIIIllllIIIIllllIIIIll for reference) to the clientside API wrapper class for an
AppInstanceinsidecf.jsandcf-wallet.js. This adds them.Field rename
limitOrTotalwasamountif TwoPartyOutcome interpreter type orlimitif ETHTransfer interpreter type.beneficiarieswasplayerAddrsif TwoPartyOutcome else meaningless (but set to[0x0, 0x0])