fix: declare Digest dependency and zero XS digest buffer - #71
Draft
toddr-bot wants to merge 2 commits into
Draft
Conversation
Add Digest to PREREQ_PM and cpanfile — the Digest::base integration (PR cpan-authors#58) introduced a runtime dependency that was never declared. On minimal Perl installations where core modules are split into packages, this causes "Can't locate Digest/base.pm" at load time. Zero d_str[20] in rmd160_digest after copying bytes into the SV. This stack-local buffer held the final digest and was the last unzeroed crypto buffer in the call chain (struct: cpan-authors#39, MDfinish: cpan-authors#44, secure_memzero: cpan-authors#50, update X[]: cpan-authors#52, update/final: cpan-authors#67, compress: cpan-authors#68).
The cpm dependency manager now requires Perl 5.24+, breaking the Install Dependencies step on all older Perl containers (5.8-5.22). Fix by removing the Install Dependencies step from the matrix job entirely — all runtime and test dependencies (XSLoader, Carp, Test::More) are core Perl modules. Also remove AUTHOR_TESTING and RELEASE_TESTING env vars since author tests (Test::Pod, Test::Pod::Coverage) are already covered by the ubuntu and disttest jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare
Digestas a runtime prerequisite and zero the digest extractionbuffer in the XS layer.
Why
Digest dependency: The Digest::base integration (PR #58) added
use base 'Digest::base'but never declaredDigestin PREREQ_PM orcpanfile. On minimal Perl installations where core modules are packaged
separately, this causes a confusing "Can't locate Digest/base.pm" error
at load time.
d_str zeroing: The stack-local
d_str[20]buffer inrmd160_digestholds the final digest bytes and was the last unzeroed crypto buffer in
the call chain. While the security impact is minimal (the caller receives
the same data via the returned SV), this closes the last gap in the
memory-zeroing arc (struct: #39, MDfinish: #44, secure_memzero: #50,
update X[]: #52, update/final: #67, compress: #68).
How
'Digest' => 0to PREREQ_PM in Makefile.PLrequires 'Digest' => 0to cpanfilesecure_memzero(d_str, sizeof(d_str))afternewSVpvninrmd160_digestTesting
Full test suite passes. Verified
Digestappears in generated MYMETA.jsonruntime requires.
Quality Report
Changes: 3 files changed, 3 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan