-
Notifications
You must be signed in to change notification settings - Fork 778
P2996R13 Reflection for C++26 #8008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Fixed link, thanks. |
We could certainly move all the commits into a single PR and the test and review that again. Let's wait for a first round of reviews on both current PRs to settle, then we'll take it from there. |
@tkoeppe by the way, you've put the milestone date for 2025-06 as 06-31. Is that actually correct? I was under the impression that we would want to have the updated working draft in the post-Sofia mailing, if not sooner so that the ISO review process can start ASAP. |
@Eisenwave Sorry, no idea, I don't recall making that label or how it was made. Don't worry about it. We're not going to stop the process because of what a label says. |
That milestone is by me. I've moved the date to 07-15. |
1f97ede
to
dec16ef
Compare
dec16ef
to
f07c133
Compare
%FIXME: \libheaderref{meta} after renaming to meta.syn | ||
\libheaderrefx{meta}{meta.type.synop}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, please
%but I read between the lines and took editorial liberty to create it. | ||
\rSec1[meta.reflection]{Reflection} | ||
|
||
%FIXME: Jens said this should be [meta.syn] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. All headers (historic accidents notwithstanding) should be name.syn; it simplifies macro usage pointing to them so much.
source/meta.tex
Outdated
@@ -2554,6 +2570,3461 @@ | |||
\end{example} | |||
\end{itemdescr} | |||
|
|||
%FIXME: The paper doesn't actually specify that this subclause should exist, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, except that'd like to have a global rename of "meta.reflection*" labels to "meta.refl*" for space economy (without loss of clarity, in my view).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to do this as a bulk change after motions. There are quite a lot of reflections papers that would all need individual fixups otherwise, and it's making it more complicated than it needs to be.
I'll resolve those comments today. @jensmaurer when you said that types always use code font, does that mean that any use of e.g. The paper makes these italic, so I assume that's Also, does every FIXME require its own fixup commit? If yes, then there are like 20 incoming commits that each add one comma ... |
No, one big commit is good enough. This will be squashed anyway. For T, in general, we use T and U as type variables in upright code font, even if they are sort-of meta-variables. (If something could be a valid C++ snippet, we use upright code font.) Since an expression cannot always be written \tcode{E} (value category and bit-field-ness are not expressible as "E"), we use I suggest you leave |
287b93c
to
37c4fbf
Compare
37c4fbf
to
178a7f4
Compare
Alright, the PR is now in a state where all the little comma FIXME and other minor things are resolved. I'd hold off on major changes like renaming to |
Feel free to cherry-pick into #8004 once @Eisenwave is done with the library part.