-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U128 v2 #887
base: develop
Are you sure you want to change the base?
Conversation
@ckormanyos since this PR is already a monster I think I'm going to merge it once it turns green, and then do the integration work into a separate PR. There is also some demand for a boost library containing just a u128 and i128. I think it would be pretty easy to copy-paste this into such a thing. |
This is, indeed, a lot of work and I need to catch up.
I believe so. We have considered this in some form or another in numerous offline chats. I guess (u)int128 would be something like a prerequisite for (not only this, but also other) library(ies). In the old days, we did some work with |
I had previously talked with Peter Dimov about adding uint128 and int128 to core, but since this PR and an equivalent int128 would take over 11,000 lines he thinks it's best separate. A few others have said the same since these additions would be an almost 50% increase in the size of core. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #887 +/- ##
=========================================
+ Coverage 98.9% 98.9% +0.1%
=========================================
Files 235 236 +1
Lines 16955 16957 +2
Branches 1822 1822
=========================================
+ Hits 16768 16770 +2
Misses 187 187
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
@ckormanyos do you want me to wait till you have a chance to look at this before merging? It's not really stopping anything since I am now looking into SIMD for u256. |
Closes: #885