-
Notifications
You must be signed in to change notification settings - Fork 22
ci: add MSan Linux job #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
1 similar comment
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
e5fd260
to
ce365cb
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
ce365cb
to
b9c1aa0
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
b9c1aa0
to
e89e7b7
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
e89e7b7
to
b97485b
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
b97485b
to
1e2c460
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
1e2c460
to
80bdc65
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
204baa9
to
7cd0ed0
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
1 similar comment
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
7cd0ed0
to
30b4802
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
280a1e3
to
b1243c0
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
b1243c0
to
c97a7af
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
c97a7af
to
05a37f3
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
05a37f3
to
03aa207
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
03aa207
to
43fdecd
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
Only if bootstrap is not a source of truth, which it attempts to be In fact, one future plan is to replace literally everything in CI with a single call to bootstrap.py |
43fdecd
to
3abace9
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
@sdarwin, is it possible to tell the bot to only make this comment once per PR? |
3abace9
to
23cefa8
Compare
An automated preview of the documentation is available at https://950.mrdocs.prtest2.cppalliance.org/index.html |
@alandefreitas reviewing the available settings in Jenkins, there is a possibility: "Ignore Pull Requests marked as Drafts". Coincidentally, a pull request that's in very active development, getting 100 updates, is probably a "draft", right? It's not ready to merge. |
It's not possible to turn PRs back into drafts on GitHub. FWIW this shouldn't have to rely on that, specially in this case where the url doesn't even change. I have seen similar bot actions, where even when there is an actual update, the bot just updates the existing comment in place, instead of adding a new comment. |
It's now a draft. |
TIL you can do that, where is the option? |
Not sure what your current collaboration settings are, if "administrator" (as Alan) there's a "convert to draft" setting near "Reviews". |
Phew |
66f3bf1
to
003925c
Compare
003925c
to
63122dd
Compare
Adds MSan sanitizer job.
This builds libc++, if the host is capable of it and for non-release jobs, and uses it instead of the system library.
This libc++ will be built with whatever sanitizer is selected, increasing the effectiveness of those tests.
This is also a requirement for MSan, which requires everything to be compiled with it.
Building the libc++ separately, with the host compiler, also decreases the maximum amount of disk space the CI jobs need.
In terms of host compiler, the libc++ being used requires [apple-]clang >= 19 or GCC 15. The other compilers are still built in the pre-existing manner, using the bootstrap build.
For now, GCC 15 doesn't use this yet, because there is some issue linking the library which needs to be investigated.
apple-clang, when built with sanitizers, also has a special requirement which is not being met, so is also not opting into the standalone libc++ build. This is left to improve later.