Inline method Improvement #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add test for each fixed bug? |
sure I will |
lyriccoder
reviewed
Oct 14, 2020
| original_func = dict_original_invocations.get(invocation_node.member)[0] # type: ignore | ||
| body_start_line, body_end_line = method_body_lines(original_func, file_path) | ||
| text_lines = read_text_with_autodetected_encoding(str(file_path)).split('\n') | ||
|
|
||
| line_to_csv = [ | ||
| str(file_path), | ||
| file_path, |
There was a problem hiding this comment.
here must be a string, otherwise there will be dirty string like Path("A/b/A") instead of "A/b/A"
There was a problem hiding this comment.
У меня кстати не было такого
lyriccoder
reviewed
Oct 14, 2020
| @@ -267,7 +264,7 @@ def insert_code_with_new_file_creation( | |||
| return line_to_csv | |||
|
|
|||
|
|
|||
| def analyze_file(file_path: Path, output_path: Path) -> List[Any]: | |||
| def _analyze_file(file_path: Path, output_path: Path) -> List[Any]: | |||
There was a problem hiding this comment.
why do u make _ before each function? It's not a private function
There was a problem hiding this comment.
Я удалил потом
lyriccoder
reviewed
Oct 14, 2020
|
|
||
|
|
||
| class InlineWithReturnWithoutArguments(IBaseInlineAlgorithm): | ||
|
|
||
| def __init__(self): | ||
| super().__init__() | ||
|
|
||
| def inline_function( | ||
| def get_lines_before_invocation( |
There was a problem hiding this comment.
You have the same function. I see, we have a code duplication, extract this default functionality to a protected method in the base abstract class
Vitaly-Protasov
force-pushed
the
issue-50_1
branch
from
1cdd52b
to
01a0c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed in #50