fix: Add typeName to @OperationParam for String parameters #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes HAPI-1716 errors when using these providers with HAPI FHIR 8.x. HAPI FHIR 8.x has stricter type checking for @OperationParam annotations. When using java.lang.String without specifying typeName, HAPI FHIR tries to scan String as a FHIR resource class, which fails with: HAPI-1716: Resource class[java.lang.String] does not contain any valid HAPI-FHIR annotations The fix adds typeName = "string" to all @OperationParam annotations that use String parameters. This tells HAPI FHIR to treat the parameter as a FHIR string type mapped to a Java String. Affected providers: - r4/plandefinition/PlanDefinitionApplyProvider - r4/activitydefinition/ActivityDefinitionApplyProvider - r4/graphdefinition/GraphDefinitionApplyProvider - dstu3/plandefinition/PlanDefinitionApplyProvider - dstu3/activitydefinition/ActivityDefinitionApplyProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a
Failure during REST processing: ca.uhn.fhir.context.ConfigurationException: HAPI-1716: Resource class[java.lang.String] does not contain any valid HAPI-FHIR annotationserror when callingPlanDefinition/$applyin the HAPI FHIR JPA server starter project (using HAPI FHIR 8.6.0).It seems that HAPI relies on either a
typeNameannotation or requires the use of typed classes such asStringType.The fix adds typeName = "string" to all @OperationParam annotations that use String parameters.
Affected providers:
Note that I tested this only with the R4
PlanDefinitionApplyProvider.