#1575: Fixed the implementation of equivalent for ratios

[antvaset]

Closes #1575:

• Fix the equivalent logic for ratios to make e.g. 1'cm':2'cm' ~ 2'cm':4'cm' evaluate to true. The result is calculated as equivalent(a.numerator * b.denominator, b.numerator * a.denominator).
• Fix the divide evaluator to make dividing by a 0-valued quantity return null. Previously it threw a NullPointerException.

[github-actions]

Formatting check succeeded!

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.92%. Comparing base (cc091d4) to head (00b2b02).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
.../cqf/cql/engine/elm/executing/DivideEvaluator.java	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1576   +/-   ##
=========================================
  Coverage     64.92%   64.92%           
+ Complexity     1981     1976    -5     
=========================================
  Files           499      499           
  Lines         28814    28820    +6     
  Branches       5667     5667           
=========================================
+ Hits          18707    18711    +4     
- Misses         7795     7797    +2     
  Partials       2312     2312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scymtym]

Sorry I didn't communicate this in the bug report (only here) but I have a branch that fixes Equivalent for Ratio and Quantity as well as the other comparison operators and arithmetic operators for Quantity by adding the required unit conversions. Should I submit that pull request in parallel or wait for this one?

[scymtym]

I submitted my branch as a pull request for reference.

[antvaset]

Hi @scymtym I'd tackle this separately from the broader "unit-aware quantity operations" feature, so this PR is good to go first while yours is in review. I can jump on to reviewing your PR next (which is very impressive!).

I did like your equivalent implementation better so I've changed this PR to use MultiplyEvaluator.

[sonarqubecloud]

Quality Gate failed

Failed conditions
79.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud