Skip to content

Add confirm description #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlukkezen wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add confirm description #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4f82f4
Merge pull request #62 from crahan/dev
crahan Sep 15, 2021
6296942
Add confirm description
Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ipyfilechooser/filechooser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def __init__(
title: str = '',
select_desc: str = 'Select',
change_desc: str = 'Change',
confirm_desc: str | None = None,
show_hidden: bool = False,
select_default: bool = False,
dir_icon: Optional[str] = '\U0001F4C1 ',
Expand All @@ -46,6 +47,7 @@ def __init__(
self._show_hidden = show_hidden
self._select_desc = select_desc
self._change_desc = change_desc
self._confirm_desc = confirm_desc
self._select_default = select_default
self._dir_icon = dir_icon
self._dir_icon_append = dir_icon_append
Expand Down Expand Up @@ -325,6 +327,10 @@ def _show_dialog(self) -> None:
self._gb.layout.display = None
self._cancel.layout.display = None

# Update selection button description to confirm_desc if applicable
if self._confirm_desc is not None:
self._select.description = self._confirm_desc

# Show the form with the correct path and filename
if ((self._selected_path is not None) and (self._selected_filename is not None)):
path = self._selected_path
Expand Down Expand Up @@ -606,6 +612,9 @@ def __repr__(self) -> str:
properties += f", show_only_dirs={self._show_only_dirs}"
properties += f", dir_icon_append={self._dir_icon_append}"

if self._confirm_desc is not None:
properties += f", confirm_desc='{self._confirm_desc}'"

if self._sandbox_path is not None:
properties += f", sandbox_path='{self._sandbox_path}'"

Expand Down