fix: panic when loading CRS with duplicate points from bytes#105
Open
timimm wants to merge 1 commit intocrate-crypto:masterfrom
Open
fix: panic when loading CRS with duplicate points from bytes#105timimm wants to merge 1 commit intocrate-crypto:masterfrom
timimm wants to merge 1 commit intocrate-crypto:masterfrom
Conversation
tx-tomcat
pushed a commit
to Loragon-chain/rust-verkle
that referenced
this pull request
Dec 21, 2025
- Add CRSError enum with InvalidLength, DuplicatePoints, and PointDeserializationError variants - Add try_from_bytes_uncompressed method to Element for safe deserialization - Update CRS::from_bytes to return Result<CRS, CRSError> - Add validate_no_duplicates helper for duplicate point detection - Add deprecated from_bytes_unchecked wrapper for backward compatibility - Add comprehensive unit tests for all error paths - Add thiserror dependency to ipa-multipoint Closes part of PR crate-crypto#105 - fixes panic on invalid CRS bytes 🤖 Generated with [Claude Code](https://claude.com/claude-code)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.