-
Notifications
You must be signed in to change notification settings - Fork 31
Improve test suite #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve test suite #401
+67
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@amotl what about the test failures? |
seut
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ok got it, test failures should be solved by #397. |
db8a8e4
to
6472212
Compare
0e59669
to
8758f08
Compare
This is the foundation to improve the situation later by adding support for running CrateDB through Docker or other means.
- Send Content-Length header based on the encoded response body - Reduce sleep time after starting the server thread
8758f08
to
bfc41b5
Compare
mfussenegger
approved these changes
Mar 29, 2021
bfc41b5
to
3335961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
based on this patch, it becomes easier to selectively run parts of the test suite. This is important to me because the whole test suite is currently only able to be invoked exclusively on Linux.
With kind regards,
Andreas.