-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test dynamic column names in resultsets with less partitions created #346
base: master
Are you sure you want to change the base?
Conversation
This reverts commit a5f3a3f.
7e2318e
to
ffe5ee3
Compare
ffe5ee3
to
aa5bd13
Compare
Hi @matriv , I think my previous approach created more partitions/shards than it needed to and caused time outs / weird state of the cluster leading to such exceptions. Could you take a look at this? Also do you think it is worth to investigate how the
|
Sorry I don't get your approach now, why do you need a new table, but keep a dynamic object on the partitioned table? Also why did you restrict the inserts to only 2 versions? |
Those are results of the reversion, it would be clearer to check the last commit of the two. |
Thank you @jeeminso, I was confused before. |
retest this please |
The exception due to noneType is gone with the approved changes but still timing out, even removing most of the test added originally did not help. I am guessing it is some kind of env issue. |
retest this please |
3 similar comments
retest this please |
retest this please |
retest this please |
Summary of the changes / Why this is an improvement
Improves #344.
Checklist