-
Notifications
You must be signed in to change notification settings - Fork 5
Replace black with ruff and fix import declarations and f string #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
0392689
b9670f7
f33109e
e22b722
46ade35
b745e96
56f034a
e645521
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ uv run pytest | |
| ## Lint | ||
|
|
||
| ```bash | ||
| uv run black . --check | ||
| uv run ruff check . | ||
| ``` | ||
|
|
||
| ## Build | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import datetime, uuid | ||
| import datetime | ||
| import uuid | ||
|
|
||
| from django.db.models import F | ||
|
|
||
|
|
||
|
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this patch. Writing down the dependency for ruff is better like this, to not cause any behaviour drift, due to new formatting rules, and deprecations of older ones, coming from future releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. I was checking other repositories and didn't understand this at first when I saw it. Now I understand why it's done this way.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot also understands this paradigm, and will submit corresponding patches, so maintainers can either merge without ado (if nothing changes), or accompany the PR with required adjustments about code formatting rules coming from a newer minor version of ruff.