-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloader enhancement #685
Conversation
I think this may not be as easy as os-arch-libc. Libraries built with glibc 2.17 may not be usable in compilation with glibc >=2.18. I love the idea, but I'm not sure how realistic this is for non-musl. We may have to only allow this inside the spc-gnu-docker container and throw an error otherwise. Luckily musl build is not affected from this. |
We assume all developers build glibc using spc-gnu-docker or CentOS 7 just like described in the documentation. But what you said makes sense. Maybe we should add an obvious warning or add a libc version suffix? |
Yes, I think os-arch-libc-libcversion should suffice. Since it wouldn't match on non 2.17, it would simply reuse the current functionality of falling back to source download. Good idea. |
Another question is: But musl seems good for updating patch version num. Maybe we just use |
I think musl tries to stay forward compatible, but doesn't guarantee it. Since musl is moving very slowly, I think we could add the version string there too. I think this is the better idea because the fallback stays functional, whereas a musl forward compatibility break would cause spc to fail. |
My IP has been banned by GitHub from accessing the API... But everything seems to be working fine so far, including automatic packaging of pre-builts. https://github.com/static-php/static-php-cli-hosted/actions/runs/14156711781 |
What does this PR do?
Fix #682
Checklist before merging
*.php
, runcomposer cs-fix
at local machine.src/global/test-extensions.php
../docs/
.config/xxx.json
content, runbin/spc dev:sort-config xxx
.