workaround self sufficient check for crc

[anjannath]

Summary by CodeRabbit

• Chores
  • During VM initialization, create a default marker file that sets the CRC self-sufficiency flag to "off" (CRC_SELF_SUFFICIENT=0).
  • The marker is written remotely late in the setup sequence after package installation and unit copying, before image cleanup.
  • No other initialization behavior or control flow is changed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Warning

Rate limit exceeded

@anjannath has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4efd234 and ed07fbe.

📒 Files selected for processing (1)

• createdisk.sh (1 hunks)

Walkthrough

Adds a VM initialization step that writes /etc/sysconfig/crc-env with CRC_SELF_SUFFICIENT=0 via SSH. The step runs after systemd-related setup (install_additional_packages and copy_systemd_units) and before cleanup_vm_image; no other control flow changes.

Changes

Cohort / File(s)	Summary
VM Configuration Marker createdisk.sh	Adds an SSH-executed command to create /etc/sysconfig/crc-env containing CRC_SELF_SUFFICIENT=0, placed after systemd setup and before VM cleanup.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Local as Local build host
  participant VM as Provisioned VM

  Note over Local,VM: Existing initialization sequence
  Local->>VM: install_additional_packages()
  Local->>VM: copy_systemd_units()
  Note over Local,VM: NEW — marker file creation
  Local->>VM: ssh "echo 'CRC_SELF_SUFFICIENT=0' > /etc/sysconfig/crc-env"
  Note right of VM: /etc/sysconfig/crc-env created
  Local->>VM: cleanup_vm_image()

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single-file change with one added SSH command.
• Check correctness of quoting, file permissions, idempotency, and whether the file write should use sudo.
• Verify placement relative to systemd units and cleanup step.

Poem

🐰 I wrote a tiny file in the VM's green glade,
CRC_SELF_SUFFICIENT set to zero—neat and staid.
No cloud-init dance, just a quiet little cheer,
The bundle wakes ready, the path now clear. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "workaround self sufficient check for crc" directly describes the main change in the pull request, which adds a marker file to work around a CRC self-sufficient compatibility check. The title is concise, clear, and uses specific terms that accurately convey the nature of the change without vague language or noise. A developer scanning the history would understand that this PR addresses a workaround related to CRC's self-sufficient check mechanism.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anjannath]

/retest

[anjannath]

/test e2e-snc-4.20.0

[anjannath]

/test e2e-snc

[openshift-ci]

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-microshift	ed07fbe	link	true	/test e2e-microshift
ci/prow/e2e-snc	ed07fbe	link	true	/test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[praveenkumar]

/cherry-pick master

[praveenkumar]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@praveenkumar: new pull request created: #1187

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@praveenkumar: new pull request created: #1188

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.