Skip to content

chore: remove 'black' lint references in favor of 'ruff' #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 15, 2025
Merged

chore: remove 'black' lint references in favor of 'ruff' #186

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf8a06f
remove outdated reference to Black formatting, done by robots now
crccheck Aug 6, 2025
0673956
feat(ci): cache pip requirements
crccheck Aug 6, 2025
82379ef
combine pip install
crccheck Aug 6, 2025
202de42
feedback: hash deps in pip cache
crccheck Aug 6, 2025
fe15672
nevermind, caching aint easy
crccheck Sep 15, 2025
58a7e6f
delint
crccheck Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,14 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- run: pip install -e '.[dev]'
- run: pip install "Django==${{ matrix.django-version }}.*"
- name: Cache pip
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }}
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache key should include a hash of requirements files to ensure cache invalidation when dependencies change. Consider adding a hash of setup.py or requirements files to the key pattern.

Suggested change
key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }}
key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }}-${{ hashFiles('setup.py', 'requirements.txt', 'pyproject.toml') }}

Copilot uses AI. Check for mistakes.
restore-keys: |
${{ runner.os }}-pip-
- run: pip install -e '.[dev]' "Django==${{ matrix.django-version }}.*"
- run: make test

lint:
Expand Down
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
This project uses [Black] to format code. To avoid manually running `black .`,
you can install a Git hook or a format-on-save plugin for your editor.

[Black]: https://github.com/psf/black