Fix commit ordering and traversal for logWalk #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GTRI-nathan and welcome as a first-time contributor! Would it be possible to add a test verifying the issue you saw? Our test suit is a bit sparse at the moment, but you can find tests in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compare function was comparing objects instead of seconds, always returning the same result (false, I believe). I believe it is correct to compare just seconds without the offset, as I believe seconds should be since the Unix epoch which is timezone independent, but I'm not positive. When fixed, it revealed that the seen map was not being updated during the walk, leading to duplicate commits being emitted (would walk down both sides of a merge and then the shared history twice).