utf8 support #11
Merged
utf8 support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 18, 2012 21:28
|
Thanks James! |
|
Published to npm as [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request firstly refactors the test.js into a proper test suite that you can run with
npm testand it will output TAP and give you an exit code of 0 on success. I then added a failing utf8 test so I could make it pass. The test suite will be useful for getting this module running with browser tests on testling-ci, which I will hack together shortly.If you don't want any of the test commits you can just cherry-pick fba4e12 which has the actual fix but the tests are nice.
Fixes issue #7.