Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed help section links #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saurabhack
Copy link

@saurabhack saurabhack commented Feb 11, 2025

Fixes

Fixes #544 by @saurabhkamane

Description

  • Converted button-like links into real <a> tags to improve accessibility and standardize link behavior.
  • Ensured all links open in a new tab using target="_blank" with rel="noopener noreferrer".

Technical details

  • Updated clickHandler to prevent default behavior.
  • Used Vue's $nextTick to properly modify modal links after the DOM updates.

Tests

  1. Run the project locally.
  2. Go to the Help section.
  3. Click on each link and confirm they open in a new tab.

Screenshots

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the main branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tested the changes locally.

Developer Certificate of Origin

By submitting this PR, I confirm that I have the right to submit this contribution under the project's open-source license.

@saurabhack saurabhack requested review from a team as code owners February 11, 2025 19:28
@saurabhack saurabhack requested review from TimidRobot, possumbilities and zackkrida and removed request for a team February 11, 2025 19:28
Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for creativecommons-chooser failed.

Name Link
🔨 Latest commit 82d1126
🔍 Latest deploy log https://app.netlify.com/sites/creativecommons-chooser/deploys/67aba4ea7125950008b7db27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Links are actually buttons
1 participant