-
-
Notifications
You must be signed in to change notification settings - Fork 60
Add Flickr data fetching automation #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Flickr data fetching automation #197
Conversation
Fetches CC license data for all 8 license types from Flickr API. Includes GitHub Actions integration and CSV output. Resolves creativecommons#164
d3db8a6 to
fd8e294
Compare
|
@SaurabhCodesAI This pull request (PR) is unacceptable due to a failure to follow the PR template instructions. |
|
@SaurabhCodesAI did you use any AI tools when creating |
|
@TimidRobot Thanks for checking the API pricing details and marking this as blocked. About AI: No, I didn't use AI to write the code. I'm aware this project's guidelines prohibit AI generated code, and I respect that. I have experience building multi API projects solo (you can check my GitHub profile). I studied For context: In my personal projects, I use AI to generate detailed comments so others learning from my code can understand what each line does. But for actual contributions to open source projects, I follow the project's guidelines and write everything myself. About the API access: I mentioned the Pro subscription issue 6 hours ago in my comment, but went ahead with the implementation thinking CC might have existing access. Should have asked you first, my mistake. I'll close this PR since the data source isn't viable. Next steps: I'd still like to contribute to this project. Would you be open to me spending more time going through the codebase and proposing a different feature or improvement? Or would you prefer I look into alternative platforms with free APIs that might work as data sources? Thanks for your time and feedback on this. |
|
Yeah, sorry about the API access. Flickr's documentation contradicts itself 😢 I'm also concerned that this PR is nearly identical to #194. How did that happen? |
|
@TimidRobot About the similarity to #194: Honestly, I reviewed their PR because I wanted to make sure I was on the right track. I saw they submitted a PR without joining the discussion first, so I figured maybe they were experienced and knew exactly what to do. When I looked at their code, I noticed it was missing licenses 1 and 9, and the license names didn't match the official Flickr API. That made me double check my own implementation to make sure I had all 8 licenses and the correct names. Both PRs look similar because we both followed The main differences:
I wanted to make sure my implementation met the project's standards, especially since I saw someone else had already jumped in. If I'd been the only one working on it, I would have taken more time to plan it out carefully like you originally suggested. No worries about the API situation, that outdated documentation got both of us! |
Fixes
Description
This PR implements automation for Flickr data fetching as discussed in issue #164. The implementation follows the established patterns from existing fetch scripts.
Technical details
Files Changed:
scripts/1-fetch/flickr_fetch.py- New script to fetch CC license data from Flickr API.github/workflows/1-fetch.yml- Added Flickr fetch job to the workflowKey Features:
github_fetch.pyandgcs_fetch.py--devmode for testing without API credentialsCommand Options:
--limit- Limit photos per license (default: 100)--enable-save- Save results to CSV--enable-git- Enable git operations--dev- Development mode with fake dataTests
Tested in dev mode:
All 8 licenses fetched correctly with proper CSV output.
Note: Unable to test with live Flickr API as they now require PRO subscription for API access. The implementation follows established project patterns and should work once credentials are available.
Screenshots
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin