New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env var name typo, missing S #3539

Merged

veganstraightedge merged 1 commit into main from fix_puma_config_env_var_typo

Sep 14, 2023

Contributor

veganstraightedge commented Sep 14, 2023

Oops.

RAILS_MAX_THREAD in puma.rb RAILS_MAX_THREADS in env var. 😂


          Fix env var name typo, missing S

0fccdd4

veganstraightedge requested review from astronaut-wannabe, bookis, eliduke, evanphx, guitsaru and just1602 as code owners

September 14, 2023 20:45

veganstraightedge merged commit ff9ef45 into main

veganstraightedge deleted the fix_puma_config_env_var_typo branch

September 14, 2023 20:47

Collaborator

just1602 commented Sep 15, 2023

@veganstraightedge I'm wondering what were the defaults? Also, would it help to enable yjit with a specified number of threads? #3039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

astronaut-wannabe Awaiting requested review from astronaut-wannabe astronaut-wannabe is a code owner

bookis Awaiting requested review from bookis bookis is a code owner

eliduke Awaiting requested review from eliduke eliduke is a code owner

evanphx Awaiting requested review from evanphx evanphx is a code owner

guitsaru Awaiting requested review from guitsaru guitsaru is a code owner

just1602 Awaiting requested review from just1602 just1602 is a code owner

Labels

None yet