Set unified_mode on custom resources #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josqu4red
force-pushed
the
unified_mode
branch
2 times, most recently
from
cc2c880 to
04917e8
Compare
Rework nssm_install resource to remove :before notification which does not work in unified mode in that case.
josqu4red
force-pushed
the
unified_mode
branch
from
04917e8 to
a2d1f85
Compare
3 tasks
jeremy-clerc
approved these changes
Nov 19, 2021
| property :servicename, String, name_property: true | ||
| property :program, String, required: true | ||
| property :args, String | ||
| property :parameters, Hash, default: lazy { ::Mash.new } | ||
| property :nssm_binary, [String, NilClass], default: lazy { ::NSSM.binary_path node } | ||
| property :start, [TrueClass, FalseClass], default: true | ||
| property :start, [true, false], default: true |
There was a problem hiding this comment.
Rubocop fix ? Not sure how it is related to the unified mode commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.