Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable/fix failing targets #1432

Merged
merged 9 commits into from
Feb 6, 2024
Merged

disable/fix failing targets #1432

merged 9 commits into from
Feb 6, 2024

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Feb 1, 2024

Touches on
#1422
#1423
#1424

resolves #1425 (kinda)

@Emilgardis Emilgardis requested a review from a team as a code owner February 1, 2024 20:55
@Emilgardis
Copy link
Member Author

/ci try

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member Author

/ci try

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member Author

/ci try -t riscv64gc-unknown-linux-gnu

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member Author

/ci try -t riscv64gc-unknown-linux-gnu

This comment has been minimized.

@Emilgardis
Copy link
Member Author

/ci try -t riscv64gc-unknown-linux-gnu

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Feb 2, 2024

Try run for comment

Successful Jobs

@Emilgardis Emilgardis changed the title disable failing targets disable/fix failing targets Feb 2, 2024
@Emilgardis
Copy link
Member Author

Going to merge this for now, we can work on reintroducing these targets in other prs

@Emilgardis Emilgardis added this pull request to the merge queue Feb 6, 2024
@Emilgardis Emilgardis removed this pull request from the merge queue due to a manual request Feb 6, 2024
@Emilgardis
Copy link
Member Author

Emilgardis commented Feb 6, 2024

Actually, I'm going to wait with this a bit and add some more utility to disabled, would be nice to still let people use whatever image exists, just add some logic:

if build is dev (e.g built from source via local clone), consider using disabled provided images, otherwise, don't

@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Feb 6, 2024
@Emilgardis
Copy link
Member Author

or no, can do that later

@Emilgardis Emilgardis added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 15ba0b1 Feb 6, 2024
21 of 22 checks passed
@Emilgardis Emilgardis deleted the disable-failing branch February 6, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix zig image
1 participant