Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix riscv64gc-unknown-linux-gnu target #1525

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Fix riscv64gc-unknown-linux-gnu target #1525

merged 7 commits into from
Jul 11, 2024

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Jul 10, 2024

Fix #1423

@kxxt kxxt requested a review from a team as a code owner July 10, 2024 11:49
@Emilgardis Emilgardis added the CI-riscv64gc-unknown-linux-gnu Run CI for riscv64gc-unknown-linux-gnu target label Jul 10, 2024
@Emilgardis
Copy link
Member

/ci try

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@kxxt
Copy link
Contributor Author

kxxt commented Jul 10, 2024

Try run for comment

* [try / conclusion](https://github.com/cross-rs/cross/actions/runs/9875806339/job/27274289849?pr=1525#) - ❌

Failed Jobs

* [riscv64gc-unknown-linux-gnu](https://github.com/cross-rs/cross/actions/runs/9875806339/job/27273623828?pr=1525#) - ❌

The qemu-system runner failure should be fixed now by 64f448d and 2074355

@Emilgardis
Copy link
Member

/ci try

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Try run for comment

Successful Jobs

@Emilgardis
Copy link
Member

Emilgardis commented Jul 10, 2024 •
edited
Loading

Awesome!

The readme probably needs to be updated due to the 22.04 change, can you run cargo xtask target-info --tag local riscv64gc-unknown-linux-gnu after having built the image. I can do it myself if you're not able to

@kxxt
Copy link
Contributor Author

kxxt commented Jul 11, 2024

The readme probably needs to be updated due to the 22.04 change, can you run cargo xtask target-info --tag local riscv64gc-unknown-linux-gnu after having built the image. I can do it myself if you're not able to

Done. The target info xtask cannot get libc version because libc-$major-$minor.so.$abi doesn't exist. There's only libc.so.6 so I updated the logic to retrieve libc version via dpkg.

Emilgardis
Emilgardis approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM

@Emilgardis Emilgardis added this pull request to the merge queue Jul 11, 2024
Merged via the queue into cross-rs:main with commit 7b79041 Jul 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
CI-riscv64gc-unknown-linux-gnu Run CI for riscv64gc-unknown-linux-gnu target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix riscv64gc-unknown-linux-gnu
2 participants
@kxxt @Emilgardis