chore: added observedGeneration to the Ready and Sync condition #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Nunes <[email protected]>
|
@pintonunes Hey, this looks great and like something we could really use in our team! But I guess the change set needs some test coverage, and that this may be the reason why the PR hasn't progressed yet @turkenh? |
|
Sorry for the long delay.. I will add this to the reconciler tests. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Today is pretty impossible to know when a managed resource is fully reconciled after an update.
On creation we can check the
ReadyandSyncconditions to beTruebut on updates we never know if what we are seeing is the actual or the previous state.Imagine we are updating an RDS cluster (long running async update) and by looking to the CR we cant tell if the update is done, in progress or if the controller is actually dead.
This PR adds the
observedGenerationto theReadyandSyncconditions in the main reconcile loop since it was introduced with #633Related with:
crossplane/crossplane#4695
crossplane/crossplane#4655
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.