fix: handle sigterm #130
Closed
fix: handle sigterm #130
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Fernández <[email protected]>
Signed-off-by: Jesús Fernández <[email protected]>
fernandezcuesta
force-pushed
the
main
branch
from
bbd0315 to
50b187c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Python based functions are not properly handling SIGTERM and as a consequence, are slow to shut down as raised in #109.
This PR adds a handler for SIGTERM which essentially calls server.stop() to gracefully terminate connections with a given grace period (5 seconds).
Fixes #109
I have: