Problem(v53 backport) : block-stm, object store etc #1688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thomas-nguy
force-pushed
the
release/v0.53.x-mavis
branch
3 times, most recently
from
67a9496 to
a05ea21
Compare
thomas-nguy
force-pushed
the
release/v0.53.x-mavis
branch
from
a05ea21 to
f489cad
Compare
thomas-nguy
changed the title
randy-cro
reviewed
Aug 20, 2025
| app.finalizeBlockState.SetContext( | ||
| app.finalizeBlockState.Context(). | ||
| WithBlockGasMeter(gasMeter). | ||
| WithTxCount(len(req.Txs)), |
There was a problem hiding this comment.
not sure if txCount is used anywhere. cant find any usage in cronos side, maybe legacy?
JayT106
force-pushed
the
release/v0.53.x-mavis
branch
from
e5e4243 to
ae1dc9e
Compare
JayT106
approved these changes
Sep 24, 2025
JayT106
left a comment
JayT106
left a comment
There was a problem hiding this comment.
LTGM, just added a unit test fix for client/v2 module
JayT106
reviewed
Sep 25, 2025
JayT106
left a comment
JayT106
left a comment
There was a problem hiding this comment.
found the cachemulti/store function doesn't match with the cronos/store. Will need to fix it.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #
Integrate our custom changes to v53
Group them in a single commit to simplify rebase in the future
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...