release: v1.5.0 #1864
release: v1.5.0 #1864
Conversation
thomas-nguy
requested review from
XinyuCRO and
randy-cro
and removed request for
a team
WalkthroughAdded an UNRELEASED v1.5.0 entry to CHANGELOG.md dated Sep 4, 2025, noting a State Machine Breaking change referencing an ibc-go upgrade to v10.1.1 (PR #1731). No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
24-24: Fix incorrect PR URLLabel is “#1851” but URL ends with “/pull/1850”. Likely a copy-paste error.
Apply this correction:
-* [#1851](https://github.com/crypto-org-chain/cronos/pull/1850) Add default value of CancunTime and PragueTime in chain config. +* [#1851](https://github.com/crypto-org-chain/cronos/pull/1851) Add default value of CancunTime and PragueTime in chain config.
🧹 Nitpick comments (3)
CHANGELOG.md (3)
5-5: Silence markdownlint MD036 for date linemarkdownlint flags the italicized date as “emphasis used instead of a heading.” This formatting is consistent with the rest of the changelog. Either disable the rule for this line or adjust tooling.
Apply this local, non-invasive fix:
+# markdownlint-disable-next-line MD036 *Sep 4, 2025*
14-14: Grammar fix in state machine breaking note“Tense/wording reads off.”
-* [#1846](https://github.com/crypto-org-chain/cronos/pull/1846) Enforce app creator returning application implement AppWithPendingTxStream during compilation phase +* [#1846](https://github.com/crypto-org-chain/cronos/pull/1846) Enforce the app creator to return an application that implements AppWithPendingTxStream during the compilation phase.
18-22: Minor copy edits for consistency and capitalizationAlign with common casing used elsewhere in the changelog.
-* [#1841](https://github.com/crypto-org-chain/cronos/pull/1841) Ci: use `golangci-lint run --fix`. +* [#1841](https://github.com/crypto-org-chain/cronos/pull/1841) CI: use `golangci-lint run --fix`. -* [#1824](https://github.com/crypto-org-chain/cronos/pull/1824) Rework on github actions. +* [#1824](https://github.com/crypto-org-chain/cronos/pull/1824) Rework GitHub Actions. -* [#1826](https://github.com/crypto-org-chain/cronos/pull/1826) Update linter and tidy up code. +* [#1826](https://github.com/crypto-org-chain/cronos/pull/1826) Update linters and tidy up code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
5-5: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
CHANGELOG.md (1)
7-8: v1.5.0 section header LGTMStructure matches existing conventions (date line preceding version header).
| *Sep 4, 2025* | ||
|
|
||
| ## v1.5.0 | ||
|
|
||
| ### State Machine Breaking | ||
|
|
||
| * [#1731](https://github.com/crypto-org-chain/cronos/pull/1804) Upgrade to ibc-go v10.1.1 |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Mismatch between PR label and link target
Label shows “#1731” but URL points to “/pull/1804”. Confirm the correct PR and make label+URL consistent.
Use this script to detect and list any PR-number/URL mismatches within the v1.5.0 block:
🏁 Script executed:
#!/bin/bash
# Find v1.5.0 section and check PR label vs URL id consistency
awk '
/## v1\.5\.0/ { in=1; next }
/^## / && in { in=0 }
in { print NR ":" $0 }
' CHANGELOG.md |
gawk -F'[][]|[(|)]' '
{
line=$0
match(line, /\[#([0-9]+)\]/, m1)
match(line, /\/pull\/([0-9]+)/, m2)
if (m1[1] && m2[1] && m1[1] != m2[1]) {
print "Mismatch at line " $1 ": label #" m1[1] " vs URL PR #" m2[1] " -> " line
}
}
'Length of output: 461
Align PR number in CHANGELOG.md
CHANGELOG.md line 11’s label [ #1731 ] conflicts with the link /pull/1804; update the label to #1804 (or correct the URL to /pull/1731) so they match.
🤖 Prompt for AI Agents
In CHANGELOG.md around line 11, the PR label "[#1731]" does not match the link
"/pull/1804"; update the entry so the PR number and URL are consistent — either
change the label to "[#1804]" to match the existing link or change the link to
"/pull/1731" to match the label; ensure both the bracketed label and the linked
URL show the same PR number.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit