Skip to content

Conversation

@XinyuCRO
Copy link
Contributor

@XinyuCRO XinyuCRO commented Sep 10, 2025

Integrate crypto-org-chain/ethermint#725

Found a useful command to update ethermint, no need to edit it manually

go mod edit -replace=github.com/evmos/ethermint=github.com/crypto-org-chain/ethermint@develop
go mod tidy

Summary by CodeRabbit

  • Documentation

    • Clarified that transaction details now include authorizationList in eth_getTransactionByHash for EIP-7702 transactions.
  • Chores

    • Updated Ethermint-related dependencies to a newer version.
    • Refreshed build metadata to align with dependency updates.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2025

Walkthrough

Updated dependency mapping for github.com/evmos/ethermint in go.mod and gomod2nix.toml to a newer pseudo-version and hash, and added a CHANGELOG entry noting inclusion of authorizationList in eth_getTransactionByHash for EIP-7702 transactions.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Added UNRELEASED note referencing PR #1867: authorizationList included in eth_getTransactionByHash for EIP-7702 transactions.
Dependency mapping
go.mod, gomod2nix.toml
Bumped github.com/evmos/ethermint replace to v0.22.1-0.20250909102334-034803df81c7 (still replacing to github.com/crypto-org-chain/ethermint). Updated gomod2nix hash accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

cronos

Suggested reviewers

  • JayT106
  • calvinaco
  • yihuang

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the main feature change—adding authorizationList to the eth_getTransactionByHash RPC response for EIP-7702 transactions—using clear, specific language aligned with the PR’s objectives.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

A hop and a bump in the go.mod meadow,
I nudge the ethermint to a fresher shadow.
Changelog whispers, “7702’s in sight,”
Lists of auth now gleam just right.
Thump-thump—hashes align, neat and tidy,
Carrot cached, dependencies ready. 🥕🐇

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch xyz/main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

socket-security bot commented Sep 10, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​crypto-org-chain/​ethermint@​v0.6.1-0.20250903101849-99c354d769c1 ⏵ v0.22.1-0.20250909102334-034803df81c775 +110010010070

View full report

@XinyuCRO XinyuCRO marked this pull request as ready for review September 10, 2025 03:45
@XinyuCRO XinyuCRO requested a review from a team as a code owner September 10, 2025 03:45
@XinyuCRO XinyuCRO requested review from randy-cro and thomas-nguy and removed request for a team September 10, 2025 03:45
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
go.mod (1)

309-309: Update trailing comment for pinned pseudo-version
go list -m and go mod tidy confirm that github.com/evmos/ethermint is correctly replaced by github.com/crypto-org-chain/ethermint v0.22.1-0.20250909102334-034803df81c7. On line 309, replace:

-    // develop
+    // develop (pinned to 034803df)
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 750d141 and 2ab1cdc.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • go.mod (1 hunks)
  • gomod2nix.toml (1 hunks)
🔇 Additional comments (2)
CHANGELOG.md (1)

22-22: Tweak phrasing for clarity
CHANGELOG.md line 22

-* [#1867](https://github.com/crypto-org-chain/cronos/pull/1867) Add authorizationList from `eth_getTransactionByHash` response for EIP-7702 transactions
+* [#1867](https://github.com/crypto-org-chain/cronos/pull/1867) Add `authorizationList` to the `eth_getTransactionByHash` response for EIP-7702 transactions

Verify that the exact casing of authorizationList matches the upstream RPC schema.

gomod2nix.toml (1)

318-320: Ensure gomod2nix is installed and re-generate lock file to verify no drift

Install the gomod2nix binary (v0.22.1) and re-run generation to confirm gomod2nix.toml hasn’t drifted and the hash remains reproducible:

go install github.com/tweag/[email protected]
gomod2nix generate
git --no-pager diff -- gomod2nix.toml | sed -n '1,200p'

@XinyuCRO XinyuCRO added this pull request to the merge queue Sep 12, 2025
Merged via the queue into main with commit 98304d8 Sep 12, 2025
37 checks passed
@XinyuCRO XinyuCRO deleted the xyz/main branch September 12, 2025 04:14
@coderabbitai coderabbitai bot mentioned this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants