-
Notifications
You must be signed in to change notification settings - Fork 273
feat(RPC): add authorizationList from eth_getTransactionByHash response for EIP-7702 transactions #1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…se for EIP-7702 transactions
WalkthroughUpdated dependency mapping for github.com/evmos/ethermint in go.mod and gomod2nix.toml to a newer pseudo-version and hash, and added a CHANGELOG entry noting inclusion of authorizationList in eth_getTransactionByHash for EIP-7702 transactions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
309-309: Update trailing comment for pinned pseudo-version
go list -mandgo mod tidyconfirm thatgithub.com/evmos/ethermintis correctly replaced bygithub.com/crypto-org-chain/ethermint v0.22.1-0.20250909102334-034803df81c7. On line 309, replace:- // develop + // develop (pinned to 034803df)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)go.mod(1 hunks)gomod2nix.toml(1 hunks)
🔇 Additional comments (2)
CHANGELOG.md (1)
22-22: Tweak phrasing for clarity
CHANGELOG.md line 22-* [#1867](https://github.com/crypto-org-chain/cronos/pull/1867) Add authorizationList from `eth_getTransactionByHash` response for EIP-7702 transactions +* [#1867](https://github.com/crypto-org-chain/cronos/pull/1867) Add `authorizationList` to the `eth_getTransactionByHash` response for EIP-7702 transactionsVerify that the exact casing of
authorizationListmatches the upstream RPC schema.gomod2nix.toml (1)
318-320: Ensure gomod2nix is installed and re-generate lock file to verify no driftInstall the gomod2nix binary (v0.22.1) and re-run generation to confirm
gomod2nix.tomlhasn’t drifted and the hash remains reproducible:go install github.com/tweag/[email protected] gomod2nix generate git --no-pager diff -- gomod2nix.toml | sed -n '1,200p'
Integrate crypto-org-chain/ethermint#725
Found a useful command to update ethermint, no need to edit it manually
Summary by CodeRabbit
Documentation
Chores