Skip to content

Conversation

@jschneider-bensch
Copy link
Contributor

@jschneider-bensch jschneider-bensch commented Sep 5, 2023

This is a first step towards a ScrambleDB demo.
I'm not happy about it, but I ended up manipulating the DOM directly from Rust instead of casting to JS types and building the tables on the JS side.

Minimal todo:

  • Fix build by adding WASM target to CI
  • Table generation for Lake/Processor table data structure
  • Generating the HTML for the blinded table crashes the WASM program, so there must be one of the unconsciously many unwraps() I put in that causes this, which means there is a bug somewhere related to blinded tables.

Of course there is much more to do for the demo to shine, at least:

  • Add interactivity to the demo
  • Presentation of tables and their contents can be much improved

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks like we have the setup now working.
Now it's about making the actual demo. What's being displayed right now doesn't tell the reader much.
You have a good description in the lib.rs. How about getting that visualised on the website. Either, just displaying all of it at once, or, to be more interactive and engaging, only show the next step on clicking a button.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelling for now to get the fixes in.
Please re-request when that's done and convert it to a PR when you're done.

@jschneider-bensch
Copy link
Contributor Author

The bugs seem to be squashed now, at least going from the spot tests and by visual inspection of the demo. There are lots more things I could (and should) test for here, though.

@franziskuskiefer
Copy link
Member

The bugs seem to be squashed now, at least going from the spot tests and by visual inspection of the demo. There are lots more things I could (and should) test for here, though.

Ok, let me know when it is ready for review.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this in with the few nits addressed.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this in with the few nits addressed.

@franziskuskiefer franziskuskiefer marked this pull request as ready for review September 23, 2023 10:45
@jschneider-bensch jschneider-bensch merged commit ad86833 into main Sep 27, 2023
@jschneider-bensch jschneider-bensch deleted the jonas/wasm-demo branch September 27, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants