Merge adjacent StringLiterals before yielding #16427
Open
+25
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16413
Joins adjacent
StringLiteralvalues before yielding within interpolations to ensure string is properly escaped if needed. E.g. in the following example:{% begin %} {% verbatim do %} {% puts %(#{2} ##{"{"}}) # => 2 #{} %} {% end %} {% end %}The string value
" \#{}"is yielded all at once, versus before each character (,#,{, and}) were all yielded on their own which prevented proper escaping of the interpolation.