Disable process cancellation during fork
#16446
Open
+120
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
ysbaddaden
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forkin a multi-threaded process is a very delicate matter. We must avoid cancelling the thread while performing a fork. Cleanup could cause problems while we're setting up the new process.This would not be necessary if we were using
vforksemantics. That's generally the better choice for spawning a new process, as there is no need to copy the entire process memory.vforkis more efficient and we should ideally use that.However, we're hoping to switch to
posix_spawneventually (#11337), which provides a safe and efficient implementation, and we don't need to deal with the details explicitly.The is currently blocked on the need to reopen stdio in the housekeeping stage (#16353) but we're expecting to resolve that soon.