[CW2-9] Add navbar / hamburger menu to mobile #8
Conversation
There was a problem hiding this comment.
Alright looks pretty good
Just some small cosmetic changes, can we make the button a bit bigger (also maybe the text a little bigger as well)? Also I think the drop down extends a bit far down, can we crop this?
I've also pushed template pages for events, about, resources, etc. So all hrefs should now point to the pages rather than the sections
components/styles.css
Outdated
There was a problem hiding this comment.
Do we need this? I think try to keep consistent to tailwind (for better or for worse)
There was a problem hiding this comment.
Yeah sorry, the animation css I got from somewhere else. I'll try and make it "proper" by Thursday!
components/Hamburger.tsx
Outdated
| > | ||
| <ul> | ||
| <li className="py-2"> | ||
| <Link href={'#about'}>About Us</Link> |
There was a problem hiding this comment.
These should all be href={'about'}
There was a problem hiding this comment.
Now all the fancy CSS animation is gone. It should be functional now.
|
Looks good |
Why the changes are required?
To add a hamburger menu to mobile
Changes
Screenshots