chore(actions): replace deployment PAT with app dispatch#224
Closed
chore(actions): replace deployment PAT with app dispatch#224
Conversation
Member
Author
|
Superseded by #227, which is rebuilt directly from instead of from an earlier PR branch. |
Member
Author
|
Superseded by #227, which is rebuilt directly from develop instead of from an earlier PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the shared
deployment-dispatch-actionin.github/workflows/docker.ymlinstead of directly checking out and editingcsesoc/deploymentfrom this repo's workflow, and split qa from ptb by publishing to distinct image names.Changes
devsoc-unsw/deployment-dispatch-action@maingithub.tokenprojects-bottoghcr.io/csesoc/projects-discord-botdeveloptoghcr.io/csesoc/projects-discord-bot-qavars.DEPLOYMENT_DISPATCHER_APP_IDandsecrets.DEPLOYMENT_DISPATCHER_APP_PRIVATE_KEYContext
This supersedes the earlier dispatch-only PR for
developbecausecsesoc/deploymentmatches manifests by image name. Without distinct image names, dispatch updates would hit both qa and ptb.Dependencies
csesoc/deploymentPR: https://github.com/csesoc/deployment/pull/3873Verification
rg -n "\\bGH_TOKEN\\b|IMAGE_NAME|projects-discord-bot-qa" . -S -g '!node_modules'actionlint -color .github/workflows/docker.ymlstill reports the same pre-existing baseline issues for old Docker action refs and the missingsteps.metadefinition