Restricted Staff Permissions #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed path filters for pull request triggers.
naasanov
requested changes
Jan 30, 2026
| const { openSidebar, closeSidebar } = useSidebar(); | ||
| const [editingStudent, setEditingStudent] = useState<StudentDto | null>(null); | ||
| const [submissionError, setSubmissionError] = useState<string | null>(null); | ||
| const { role } = useRole(); |
Collaborator
There was a problem hiding this comment.
Could move this into TableTemplate to avoid duplicated logic between tables?
| const [sidebarMode, setSidebarMode] = useState<"create" | "edit">("create"); | ||
| const [editingAccount, setEditingAccount] = useState<AccountDto | null>(null); | ||
| const [submissionError, setSubmissionError] = useState<string | null>(null); | ||
| const { role } = useRole(); |
Collaborator
There was a problem hiding this comment.
Forgot to mention in the original ticket, but we also need to make sure staff cannot see the accounts table. The impl for this would probably be in frontend/src/app/staff/page.tsx with the Tabs component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staff should only be able to view data, with the exception of checking the "is registered" checkbox on the student table
Changes:
[role?: "admin" | "staff"]field in next-auth.d.ts[RoleProvider]context in src/contexts/RoleContext.tsx and integrated it into the app providers as a placeholder until NextAuth authentication is implemented[showActions]and[showCreateButton]props to TableTemplate.tsx to conditionally render edit/delete buttons and create buttons[useRole()])hook and pass role-based permission props[showActions={role === "admin"}]to TableTemplateCloses #162