generate stubs for grpclib #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the styling changes recommended by the restyled tests. I'm unsure why they are so extensive. My changes can be seen alone at EDIT: a536a82 . I also noticed requirements.txt is not used and instead updated the README. I'm using force pushes to keep the restyling changes, which I did not expect, separate. |
xloem
force-pushed
the
grpclib
branch
4 times, most recently
from
e98e55b to
7ed2af3
Compare
grpclib is a pure-python grpc library at https://github.com/vmagamedov/grpclib because grpcio generates stubs into [name]_pb2_grpc.py, and grpclib generates stubs into [name]_grpc.py, both stubs can coexist peacefully in the same package, although it would be clearer to rename the files based on the backend they assume is present.
|
Hi, thank you for the PR and sorry for my late answer. I am a bit busy lately but I will give it in the upcoming days! |
|
I've updating the restyling changes so the tests pass again. Still not sure why the tests want them in areas I haven't touched. Haven't looked at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpclib is a pure-python grpc library at https://github.com/vmagamedov/grpclib
EDIT: grpclib's 0.4.5 release addresses the minor bug i mentioned here and i've force-pushed a requirements.txt that references it.
because grpcio generates stubs into [name]_pb2_grpc.py, and grpclib generates stubs into [name]_grpc.py, both stubs can coexist peacefully in the same package, although it would be clearer to rename the files based on the backend they assume is present.