-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(schema-compiler): Use views join maps amd hints for query joins construction #10039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KSDaemon
wants to merge
20
commits into
master
Choose a base branch
from
fix/improve-join-hints-4-proxies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7694d20
to
3d50b65
Compare
f8d8bff
to
e42d916
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10039 +/- ##
===========================================
+ Coverage 48.81% 77.10% +28.29%
===========================================
Files 196 440 +244
Lines 15787 89288 +73501
Branches 3099 3101 +2
===========================================
+ Hits 7706 68849 +61143
- Misses 7692 20050 +12358
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
waralexrom
approved these changes
Oct 9, 2025
e7d51ee
to
47e7872
Compare
predecessors comparator OMG! Is it really working?! everything works besides loop detection correct additional hints: everything works besides loop detection
fix actually incorrect tests
47e7872
to
bea009e
Compare
bea009e
to
5f0758d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
This fixes #9852
Supersedes #9995
Check List