Skip to content

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Oct 8, 2025

This PR includes:

  • Fix incorrect join path resolving for views
  • Use views join maps for query joins construction

This fixes #9852

Supersedes #9995

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon changed the base branch from master to fix/join-paths October 8, 2025 13:37
@KSDaemon KSDaemon force-pushed the fix/improve-join-hints-4-proxies branch from 7694d20 to 3d50b65 Compare October 8, 2025 14:00
@KSDaemon KSDaemon marked this pull request as ready for review October 8, 2025 14:31
@KSDaemon KSDaemon requested a review from a team as a code owner October 8, 2025 14:31
@KSDaemon KSDaemon changed the title feat(schema-compiler): Use views join maps for query joins construction feat(schema-compiler): Use views join maps amd hints for query joins construction Oct 9, 2025
@KSDaemon KSDaemon changed the base branch from fix/join-paths to master October 9, 2025 11:26
@KSDaemon KSDaemon force-pushed the fix/improve-join-hints-4-proxies branch from f8d8bff to e42d916 Compare October 9, 2025 11:27
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.10%. Comparing base (070e6e0) to head (2c2b0ba).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 88.88% 4 Missing ⚠️
...schema-compiler/src/compiler/DataSchemaCompiler.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10039       +/-   ##
===========================================
+ Coverage   48.81%   77.10%   +28.29%     
===========================================
  Files         196      440      +244     
  Lines       15787    89288    +73501     
  Branches     3099     3101        +2     
===========================================
+ Hits         7706    68849    +61143     
- Misses       7692    20050    +12358     
  Partials      389      389               
Flag Coverage Δ
cube-backend 48.83% <88.09%> (+0.02%) ⬆️
cubesql 83.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Oct 9, 2025
@KSDaemon KSDaemon force-pushed the fix/improve-join-hints-4-proxies branch from e7d51ee to 47e7872 Compare October 10, 2025 07:55
@KSDaemon KSDaemon force-pushed the fix/improve-join-hints-4-proxies branch from 47e7872 to bea009e Compare October 10, 2025 13:10
@KSDaemon KSDaemon force-pushed the fix/improve-join-hints-4-proxies branch from bea009e to 5f0758d Compare October 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Join Path Resolution Ignores Explicit View Paths

2 participants