Feat/sql api database meta#10935
Open
SaschaJohn wants to merge 9 commits into
Open
Conversation
…equestMeta The PostgreSQL wire protocol startup message includes a `database` parameter, which is already parsed and stored on SessionState. However, it was never included in LoadRequestMeta, making it inaccessible to JS configuration callbacks like extendContext. This is needed for multi-tenant setups where the database name carries the tenant identifier (e.g. a UUID), allowing checkSqlAuth or extendContext to resolve tenant context from the client-supplied dbname. Changes: - Add `database: Option<String>` field to LoadRequestMeta (Rust) - Populate it from SessionState::database() in get_load_request_meta - Add `database?: string` to BaseMeta TypeScript interface Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
rust
Author
|
@ovr @paveltiunov may I kindly ask for a review? Would be great. Thanks in advance |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #10935 +/- ##
===========================================
- Coverage 83.53% 58.83% -24.71%
===========================================
Files 254 210 -44
Lines 75869 16603 -59266
Branches 0 3358 +3358
===========================================
- Hits 63378 9768 -53610
+ Misses 12491 6344 -6147
- Partials 0 491 +491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thread database name from PostgreSQL startup parameters through SqlAuthServiceAuthenticateRequest into CheckSQLAuthPayload, constructing LoadRequestMeta with database context when available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…h flow Update JS test assertions to expect BaseMeta with database field instead of null, and add Rust tests for database propagation through SQL query meta and default absence when not set. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#10934
Description of Changes Made (if issue reference is not provided)
expose the existing dbname from session to metadata