Conversation
…rage Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test cases for src/cuddInteract.c with 90% coverage
Add comprehensive test coverage for cuddInteract.c interaction matrix operations
Dec 6, 2025
Member
|
@copilot Investigate failures in sanitizer and valgrind tests. Then implement your solutions. |
…Cudd_Quit Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Author
Fixed sanitizer and valgrind failures in commit 6ff96bc. Root cause: The Changes made:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete test cases for src/cuddInteract.c and target 90% coverage
Final Status: ✅ 94.0% coverage achieved (79/84 lines covered)
Coverage Improvement: 8.9% → 94.0% (+85.1 percentage points)
Completed Tasks:
Test Summary:
cuddInitInteract,cuddSetInteract,cuddTestInteractMemory Management Fix:
The CUDD library has a design issue where
cuddInitInteractallocates memory for the interaction matrix butCudd_Quit(viacuddFreeTable) doesn't free it. The matrix is only freed in reordering functions. To ensure tests pass sanitizers/valgrind:cuddInitInteracttwice (causes leak)FREE(manager->interact)before allCudd_QuitcallsUncovered Lines (6%):
cuddInitInteract(interact array)cuddInitInteract(support array)These are error handling paths for memory allocation failures. The achieved 94.0% coverage significantly exceeds the 90% target.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.