Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse formatted number string to number #41

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Parse formatted number string to number #41

wants to merge 8 commits into from

Commits on Jul 9, 2021

  1. New feature: Parse formatted number string to number value based on l… 

    …ocale
    @praveentiru
    praveentiru committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    3a0fbfe View commit details
    Browse the repository at this point in the history

  2. Simplify logic as per feedback

    @praveentiru
    praveentiru committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b5a29f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2021

  1. Change summary: 

    1. Added new function joinParts to build number from parts
2. Cleaned up code in parseString as per feedback
    @praveentiru
    praveentiru committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    800e344 View commit details
    Browse the repository at this point in the history

  2. Make changes to parseString function with better naming as advised

    @praveentiru
    praveentiru committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    b80c907 View commit details
    Browse the repository at this point in the history

  3. Using elm's negate function rather than custom logic

    @praveentiru
    praveentiru committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    212afbf View commit details
    Browse the repository at this point in the history

  4. Change summary: Add new feature to parse formatted string to number 

    value based on locale
1. Add new function parse to expose new feature
2. Add new function parseString in Parser.elm to implement parse
3. Add new function joinParts to join the number parts into float
    @praveentiru
    praveentiru committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    f020856 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'parse-string' of github.com:praveentiru/elm-format-numb… 

    …er into parse-string
    @praveentiru
    praveentiru committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    da40b6f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. Minor edits based on reviewer feedback

    @praveentiru
    praveentiru committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    51f42c1 View commit details
    Browse the repository at this point in the history