Skip to content

Add missing app field to HookCheckSuite #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Mar 22, 2025

Issue reference:
I didn't make an issue as this was a TODO.
The documentation for the app in the check suite is here https://docs.github.com/en/webhooks/webhook-events-and-payloads#check_suite

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@kvanbere
Copy link
Member

Hey @ashercuedo, could you please raise an issue for this and document the intended change, then edit the PR and add the issue reference. Thanks

@ashercuedo ashercuedo merged commit 785bfcb into cuedo:develop Mar 25, 2025
1 of 18 checks passed
Copy link
Collaborator

@ashercuedo ashercuedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I created issue #82 to document exactly what this PR is targeting and have merged it.

@ashercuedo
Copy link
Collaborator

Hey @jfroche, would you like to be added to the contributors list?

@jfroche
Copy link
Contributor Author

jfroche commented Mar 26, 2025

Hey @jfroche, would you like to be added to the contributors list?

Yes, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants