fix: preserve whitespace in bulk strings #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reader.load() was using .strip() which removed all whitespace including newlines that are part of multi-line Lua scripts. Now reads exact bytes and validates terminator separately.
Owner
|
can you fix the formatting issues? |
oliverhaas
force-pushed
the
fix-tcp-server-multiline-parsing
branch
from
7601142 to
1bbb38b
Compare
Author
|
Got a little confused there... I would probably just have one test, since I don't think it's really necessary to guard against a regression here. LMK if this otherwise is fine, then I'll clean it up. |
cunla
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reader.load() was using .strip() which removed all whitespace including newlines that are part of multi-line Lua scripts. Now reads exact bytes and validates terminator separately.
See #434
I personally would just go with 1 test in the end, but just to see a few examples.