Skip to content

Add missing scope facets to Rust #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasArvidsson merged 14 commits into from
Dec 25, 2025
Merged

Add missing scope facets to Rust #3126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
17fc126
Started working on rust facets
AndreasArvidsson Dec 23, 2025
60150c3
Added more fixtures
AndreasArvidsson Dec 23, 2025
d11d8ef
Updated scope fixtures
AndreasArvidsson Dec 23, 2025
13c6b8c
Remove files
AndreasArvidsson Dec 23, 2025
20e8997
More scopes
AndreasArvidsson Dec 23, 2025
c810dba
more scopes
AndreasArvidsson Dec 23, 2025
778820a
More updates
AndreasArvidsson Dec 23, 2025
2396a29
list
AndreasArvidsson Dec 23, 2025
bc214dd
argument iteration
AndreasArvidsson Dec 23, 2025
616a02a
Added iteration scopes
AndreasArvidsson Dec 24, 2025
c704278
interior
AndreasArvidsson Dec 24, 2025
251c674
Small fixes
AndreasArvidsson Dec 24, 2025
ccd850a
Clean up
AndreasArvidsson Dec 24, 2025
5938d3a
More tests
AndreasArvidsson Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/fixtures/recorded/languages/rust/clearValue4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ command:
initialState:
documentContents: |-
fn foo() -> i32 {
return 3
return 3;
}
selections:
- anchor: {line: 1, character: 11}
Expand All @@ -22,7 +22,7 @@ initialState:
finalState:
documentContents: |-
fn foo() -> i32 {
return
return ;
}
selections:
- anchor: {line: 1, character: 11}
Expand Down
4 changes: 2 additions & 2 deletions data/fixtures/recorded/languages/rust/clearValue5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ command:
initialState:
documentContents: |-
fn foo() -> i32 {
return 3
return 3;
}
selections:
- anchor: {line: 1, character: 4}
Expand All @@ -22,7 +22,7 @@ initialState:
finalState:
documentContents: |-
fn foo() -> i32 {
return
return ;
}
selections:
- anchor: {line: 1, character: 11}
Expand Down
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/anonymousFunction.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
|| {}
---

[Content] =
[Removal] =
[Domain] = 0:0-0:5
>-----<
0| || {}

[Insertion delimiter] = "\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/anonymousFunction2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
|x| x * x;
---

[Content] =
[Removal] =
[Domain] = 0:0-0:9
>---------<
0| |x| x * x;

[Insertion delimiter] = "\n"
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.actual.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
foo(aaa, bbb);
---

[Content] = 0:4-0:12
>--------<
0| foo(aaa, bbb);

[Domain] = 0:0-0:13
>-------------<
0| foo(aaa, bbb);
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.actual.method.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
foo.bar(aaa, bbb);
---

[Content] = 0:8-0:16
>--------<
0| foo.bar(aaa, bbb);

[Domain] = 0:0-0:17
>-----------------<
0| foo.bar(aaa, bbb);
44 changes: 44 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.actual.method.multiLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
foo.bar(
aaa,
bbb
);
---

[#1 Content] =
[#1 Domain] = 1:4-1:7
>---<
1| aaa,

[#1 Removal] = 1:4-2:4
>----
1| aaa,
2| bbb
----<

[#1 Trailing delimiter] = 1:7-2:4
>-
1| aaa,
2| bbb
----<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 2:4-2:7
>---<
2| bbb

[#2 Removal] = 1:7-2:7
>-
1| aaa,
2| bbb
-------<

[#2 Leading delimiter] = 1:7-2:4
>-
1| aaa,
2| bbb
----<

[#2 Insertion delimiter] = ",\n"
33 changes: 33 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.actual.method.singleLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
foo.bar(aaa, bbb);
---

[#1 Content] =
[#1 Domain] = 0:8-0:11
>---<
0| foo.bar(aaa, bbb);

[#1 Removal] = 0:8-0:13
>-----<
0| foo.bar(aaa, bbb);

[#1 Trailing delimiter] = 0:11-0:13
>--<
0| foo.bar(aaa, bbb);

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 0:13-0:16
>---<
0| foo.bar(aaa, bbb);

[#2 Removal] = 0:11-0:16
>-----<
0| foo.bar(aaa, bbb);

[#2 Leading delimiter] = 0:11-0:13
>--<
0| foo.bar(aaa, bbb);

[#2 Insertion delimiter] = ", "
44 changes: 44 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.actual.multiLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
foo(
aaa,
bbb
);
---

[#1 Content] =
[#1 Domain] = 1:4-1:7
>---<
1| aaa,

[#1 Removal] = 1:4-2:4
>----
1| aaa,
2| bbb
----<

[#1 Trailing delimiter] = 1:7-2:4
>-
1| aaa,
2| bbb
----<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 2:4-2:7
>---<
2| bbb

[#2 Removal] = 1:7-2:7
>-
1| aaa,
2| bbb
-------<

[#2 Leading delimiter] = 1:7-2:4
>-
1| aaa,
2| bbb
----<

[#2 Insertion delimiter] = ",\n"
33 changes: 33 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.actual.singleLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
foo(aaa, bbb);
---

[#1 Content] =
[#1 Domain] = 0:4-0:7
>---<
0| foo(aaa, bbb);

[#1 Removal] = 0:4-0:9
>-----<
0| foo(aaa, bbb);

[#1 Trailing delimiter] = 0:7-0:9
>--<
0| foo(aaa, bbb);

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 0:9-0:12
>---<
0| foo(aaa, bbb);

[#2 Removal] = 0:7-0:12
>-----<
0| foo(aaa, bbb);

[#2 Leading delimiter] = 0:7-0:9
>--<
0| foo(aaa, bbb);

[#2 Insertion delimiter] = ", "
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.formal.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
fn foo(aaa: i32, bbb: i32) {}
---

[Content] = 0:7-0:25
>------------------<
0| fn foo(aaa: i32, bbb: i32) {}

[Domain] = 0:0-0:29
>-----------------------------<
0| fn foo(aaa: i32, bbb: i32) {}
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.formal.lambda.iteration.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
|aaa, bbb| {}
---

[Content] = 0:1-0:9
>--------<
0| |aaa, bbb| {}

[Domain] = 0:0-0:13
>-------------<
0| |aaa, bbb| {}
10 changes: 10 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.formal.lambda.iteration2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
|aaa: i32, bbb: i32| {}
---

[Content] = 0:1-0:19
>------------------<
0| |aaa: i32, bbb: i32| {}

[Domain] = 0:0-0:23
>-----------------------<
0| |aaa: i32, bbb: i32| {}
44 changes: 44 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.formal.lambda.multiLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
|
aaa,
bbb
| {}
---

[#1 Content] =
[#1 Domain] = 1:4-1:7
>---<
1| aaa,

[#1 Removal] = 1:4-2:4
>----
1| aaa,
2| bbb
----<

[#1 Trailing delimiter] = 1:7-2:4
>-
1| aaa,
2| bbb
----<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 2:4-2:7
>---<
2| bbb

[#2 Removal] = 1:7-2:7
>-
1| aaa,
2| bbb
-------<

[#2 Leading delimiter] = 1:7-2:4
>-
1| aaa,
2| bbb
----<

[#2 Insertion delimiter] = ",\n"
44 changes: 44 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.formal.lambda.multiLine2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
|
aaa: i32,
bbb: i32
| {}
---

[#1 Content] =
[#1 Domain] = 1:4-1:12
>--------<
1| aaa: i32,

[#1 Removal] = 1:4-2:4
>---------
1| aaa: i32,
2| bbb: i32
----<

[#1 Trailing delimiter] = 1:12-2:4
>-
1| aaa: i32,
2| bbb: i32
----<

[#1 Insertion delimiter] = ",\n"


[#2 Content] =
[#2 Domain] = 2:4-2:12
>--------<
2| bbb: i32

[#2 Removal] = 1:12-2:12
>-
1| aaa: i32,
2| bbb: i32
------------<

[#2 Leading delimiter] = 1:12-2:4
>-
1| aaa: i32,
2| bbb: i32
----<

[#2 Insertion delimiter] = ",\n"
33 changes: 33 additions & 0 deletions data/fixtures/scopes/rust/argument/argument.formal.lambda.singleLine.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
|aaa, bbb| {}
---

[#1 Content] =
[#1 Domain] = 0:1-0:4
>---<
0| |aaa, bbb| {}

[#1 Removal] = 0:1-0:6
>-----<
0| |aaa, bbb| {}

[#1 Trailing delimiter] = 0:4-0:6
>--<
0| |aaa, bbb| {}

[#1 Insertion delimiter] = ", "


[#2 Content] =
[#2 Domain] = 0:6-0:9
>---<
0| |aaa, bbb| {}

[#2 Removal] = 0:4-0:9
>-----<
0| |aaa, bbb| {}

[#2 Leading delimiter] = 0:4-0:6
>--<
0| |aaa, bbb| {}

[#2 Insertion delimiter] = ", "
Loading
Loading