feat: added new tooltips to borrow/lend/market details #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xtutti
previously approved these changes
Aug 8, 2025
…m/curvefi/curve-frontend into feat/new-position-detail-tooltips
| @@ -65,32 +68,39 @@ export const useBorrowPositionDetails = ({ | |||
| const thirtyDaysAgo = new Date() | |||
| thirtyDaysAgo.setDate(thirtyDaysAgo.getDate() - 30) | |||
|
|
|||
| const recentSnapshots = lendSnapshots.filter((snapshot) => snapshot.timestamp > thirtyDaysAgo) | |||
| const recentSnapshots = lendSnapshots.filter((snapshot) => new Date(snapshot.timestamp) > thirtyDaysAgo) | |||
There was a problem hiding this comment.
The Date conversion should be handled in the prices-api lib?
Suggested change
| const recentSnapshots = lendSnapshots.filter((snapshot) => new Date(snapshot.timestamp) > thirtyDaysAgo) | |
| const recentSnapshots = lendSnapshots.filter((snapshot) => snapshot.timestamp > thirtyDaysAgo) |
packages/curve-ui-kit/src/features/market-position-details/SupplyPositionDetails.tsx
Outdated
Show resolved
Hide resolved
packages/curve-ui-kit/src/features/market-position-details/SupplyPositionDetails.tsx
Outdated
Show resolved
Hide resolved
packages/curve-ui-kit/src/features/market-position-details/BorrowInformation.tsx
Outdated
Show resolved
Hide resolved
packages/curve-ui-kit/src/features/market-position-details/BorrowInformation.tsx
Outdated
Show resolved
Hide resolved
packages/curve-ui-kit/src/features/market-position-details/BorrowInformation.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: