fix(inbox): show the spinner while a concurrent fetch is still running

[mahmoud-elmorabea]

Follow-up to the review of #769, addressing the Bugbot finding raised against the merged feature branch.

The problem

When a queue poll is already fetching templates and branding, a concurrent overlay load() returns immediately on the repository's in-flight guard, before anything is cached. That produced a settled Hidden snapshot with loading = false, and InboxListContent renders nothing at all for Hidden — so the panel sat blank until observeContentChanges fired after the real fetch finished, instead of showing its spinner.

The fix

load() reports loading when the inbox is not yet renderable AND a fetch is still running. isFetchInFlight is exposed on VisualInbox for that check.

This brings Android in line with iOS, which already behaves correctly for a different reason: performRevalidation sets .loading before fetching, so a concurrent caller hitting its own in-flight guard returns early and leaves .loading in place.

Tests

• load_givenFetchInFlightAndNotYetRenderable_expectLoading
• load_givenHiddenAndNoFetchInFlight_expectNotLoading — the control, so a genuinely non-renderable inbox cannot spin forever

594 tests, 0 failures across messaginginapp + messaginginbox; ktlint and apiCheck clean.

---

Note

Low Risk
Localized overlay UI state logic with unit tests; no auth, data mutation, or network behavior changes.

Overview
Fixes a blank inbox panel when overlay load() runs while a queue poll is already fetching templates/branding: loadTemplatesAndBranding() returns immediately on the repository in-flight guard, so the UI used to get Hidden with loading = false and render nothing until observeContentChanges fired.

VisualInbox now exposes isFetchInFlight (from the repository). VisualInboxController.load() sets loading = true when the snapshot is not yet visible but a fetch is still running, so the panel shows its spinner instead of an empty state—aligned with iOS behavior.

Unit tests cover the in-flight loading case and the control where a settled Hidden inbox must not spin forever.

^{Reviewed by Cursor Bugbot for commit 997e5a4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.

---

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.67%. Comparing base (84d2989) to head (997e5a4).
⚠️ Report is 1 commits behind head on feat/overlay-inbox.

Files with missing lines	Patch %	Lines
...va/io/customer/messaginginapp/inbox/VisualInbox.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##             feat/overlay-inbox     #800      +/-   ##
========================================================
- Coverage                 65.95%   65.67%   -0.29%     
+ Complexity                 1290     1286       -4     
========================================================
  Files                       224      224              
  Lines                      7676     7680       +4     
  Branches                   1232     1233       +1     
========================================================
- Hits                       5063     5044      -19     
- Misses                     2218     2247      +29     
+ Partials                    395      389       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

• java_layout: inbox-review-followups (1785218927)

[github-actions]

Build available to test
Version: inbox-review-followups-SNAPSHOT
Repository: https://central.sonatype.com/repository/maven-snapshots/

[github-actions]

• kotlin_compose: inbox-review-followups (1785218922)

[github-actions]

📏 SDK Binary Size Comparison Report

Module	Last Recorded Size	Current Size	Change in Size
core	45.65 KB	45.65 KB	✅ No Change
datapipelines	42.63 KB	42.63 KB	✅ No Change
messagingpush	31.45 KB	31.45 KB	✅ No Change
messaginginapp	148.17 KB	148.17 KB	✅ No Change
messaginginbox	60.40 KB	60.46 KB	⬆️ +0.06KB
tracking-migration	22.89 KB	22.89 KB	✅ No Change
location	18.93 KB	18.93 KB	✅ No Change
geofence	78.55 KB	78.55 KB	✅ No Change